[Kos-cvs] kos/modules/lib/charfile libcharfile.c,1.3,1.4

[thomas at kos.enix.org]

Update of /home/kos/cvs/kos/modules/lib/charfile
In directory the-doors:/tmp/cvs-serv3480/modules/lib/charfile

Modified Files:
	libcharfile.c 
Log Message:
2005-01-30  Thomas Petazzoni  <thomas at crazy.kos.nx>

	* modules/x86/mm/Makefile (DEBUG_LEVEL): 1 -> 0

	* modules/vmm/_vmm_as.c: Moved as_dump and vr_dump, create
	as_dump_unsafe.

	* modules/vmm/Makefile (DEBUG_LEVEL): 3 -> 0

	* modules/tty/_tty.c, modules/tty/_tty_kres.c: DEBUG_PRINTx
	conformance + memset().

	* modules/lib/blockfile/libblockfile.c,
	modules/lib/charfile/libcharfile.c,
	modules/lib/filemap/libfilemap.c: Added memset() needed when
	allocated buffer is poisoned. Whitespaces.

	* modules/kmem/_kvmem_free.c: DEBUG_PRINTx conformance +
	whitespaces.

	* modules/kmem/_kvmem_alloc.c (kvalloc): Poison the allocated
	memory + DEBUG_PRINTx conformance.

	* modules/kmem/_kslab_cache_free.c (__kslab_cache_free_by_slab):
	Poison the freed buffer.

	* modules/kmem/_kslab_cache_alloc.c (kslab_cache_alloc): Poison
	the allocated buffer.

	* modules/kmem/_kmem_free.c (kfree): DEBUG_PRINTx conformance.

	* modules/kmem/_kmem_alloc.c (kmalloc): Whitespaces + DEBUG_PRINTx
	conformance.

	* modules/kitc/_kmutex.c: Remove [function] as they are generated
	by DEBUG_PRINTx now.

	* modules/karm/open.c: Whitespaces.

	* modules/karm/mount.c (mount): Cleaned the way of calling
	fs->attach().

	* modules/ide/_ide_karm.c: More debugging messages.

	* modules/ide/_ide.h (ide_device_info): Correct position of packed
	attribute to make gcc happy.

	* modules/part/Makefile (DEBUG_LEVEL), modules/karm/Makefile
	(DEBUG_LEVEL), modules/ide/Makefile
	(DEBUG_LEVEL), modules/fs/devfs/Makefile
	(DEBUG_LEVEL), modules/fs/fat/Makefile
	(DEBUG_LEVEL) : New variable.

	* modules/fs/devfs/devfs.c, modules/fs/fat/_fat.c,
	modules/fs/fat/_fat_karm.c: Added memset() found using the
	poisoning stuff in kmem. More debugging messages using
	DEBUG_PRINTx.

	* modules/debug/debug.h: DEBUG_PRINTx macros now call
	DEBUG_PRINT_VERBOSE instead of __dbg_printk, so that the line
	number, function and file names are printed before the debug
	message.

	* TODO: More things to do.



Index: libcharfile.c
===================================================================
RCS file: /home/kos/cvs/kos/modules/lib/charfile/libcharfile.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- libcharfile.c	29 Dec 2003 13:42:51 -0000	1.3
+++ libcharfile.c	30 Jan 2005 16:11:21 -0000	1.4
@@ -85,6 +85,8 @@
       return -ENOMEM;
     }
 
+  memset(view, 0x0, sizeof(struct view));
+
   view->iid    = INTERFACE_FILE_ID;
   view->nb_ops = INTERFACE_FILE_NB_OPS;
   view->ops    = INTERFACE_OPS(& char_file_ops);
@@ -100,6 +102,8 @@
       return -ENOMEM;
     }
 
+  memset(view_data, 0x0, sizeof(struct lcf_view_data));
+
   view_data->char_ures = char_ures;
 
   /* Register the file view to the block device */
@@ -108,6 +112,7 @@
     {
       kfree(view_data);
       kfree(view);
+      DEBUG_PRINT2("Kres add view failed : %s\n", strerror(result));
       return result;
     }