[Kos-cvs] kos/modules/tty _tty.c,1.18,1.19 _tty_kres.c,1.8,1.9

[thomas at kos.enix.org]

Update of /home/kos/cvs/kos/modules/tty
In directory the-doors:/tmp/cvs-serv3480/modules/tty

Modified Files:
	_tty.c _tty_kres.c 
Log Message:
2005-01-30  Thomas Petazzoni  <thomas at crazy.kos.nx>

	* modules/x86/mm/Makefile (DEBUG_LEVEL): 1 -> 0

	* modules/vmm/_vmm_as.c: Moved as_dump and vr_dump, create
	as_dump_unsafe.

	* modules/vmm/Makefile (DEBUG_LEVEL): 3 -> 0

	* modules/tty/_tty.c, modules/tty/_tty_kres.c: DEBUG_PRINTx
	conformance + memset().

	* modules/lib/blockfile/libblockfile.c,
	modules/lib/charfile/libcharfile.c,
	modules/lib/filemap/libfilemap.c: Added memset() needed when
	allocated buffer is poisoned. Whitespaces.

	* modules/kmem/_kvmem_free.c: DEBUG_PRINTx conformance +
	whitespaces.

	* modules/kmem/_kvmem_alloc.c (kvalloc): Poison the allocated
	memory + DEBUG_PRINTx conformance.

	* modules/kmem/_kslab_cache_free.c (__kslab_cache_free_by_slab):
	Poison the freed buffer.

	* modules/kmem/_kslab_cache_alloc.c (kslab_cache_alloc): Poison
	the allocated buffer.

	* modules/kmem/_kmem_free.c (kfree): DEBUG_PRINTx conformance.

	* modules/kmem/_kmem_alloc.c (kmalloc): Whitespaces + DEBUG_PRINTx
	conformance.

	* modules/kitc/_kmutex.c: Remove [function] as they are generated
	by DEBUG_PRINTx now.

	* modules/karm/open.c: Whitespaces.

	* modules/karm/mount.c (mount): Cleaned the way of calling
	fs->attach().

	* modules/ide/_ide_karm.c: More debugging messages.

	* modules/ide/_ide.h (ide_device_info): Correct position of packed
	attribute to make gcc happy.

	* modules/part/Makefile (DEBUG_LEVEL), modules/karm/Makefile
	(DEBUG_LEVEL), modules/ide/Makefile
	(DEBUG_LEVEL), modules/fs/devfs/Makefile
	(DEBUG_LEVEL), modules/fs/fat/Makefile
	(DEBUG_LEVEL) : New variable.

	* modules/fs/devfs/devfs.c, modules/fs/fat/_fat.c,
	modules/fs/fat/_fat_karm.c: Added memset() found using the
	poisoning stuff in kmem. More debugging messages using
	DEBUG_PRINTx.

	* modules/debug/debug.h: DEBUG_PRINTx macros now call
	DEBUG_PRINT_VERBOSE instead of __dbg_printk, so that the line
	number, function and file names are printed before the debug
	message.

	* TODO: More things to do.



Index: _tty_kres.c
===================================================================
RCS file: /home/kos/cvs/kos/modules/tty/_tty_kres.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- _tty_kres.c	29 Dec 2003 13:42:51 -0000	1.8
+++ _tty_kres.c	30 Jan 2005 16:11:21 -0000	1.9
@@ -7,7 +7,7 @@
 
 #include <tty/_tty.h>
 
-struct INTERFACE_CHAR char_ops = 
+struct INTERFACE_CHAR char_ops =
   {
     _tty_read,
     _tty_write
@@ -35,6 +35,8 @@
       return -ENOMEM;
     }
 
+  memset(view, 0, sizeof(struct view));
+
   view->iid          = INTERFACE_CHAR_ID;
   view->nb_ops       = INTERFACE_CHAR_NB_OPS;
   view->ops          = INTERFACE_OPS(& char_ops);
@@ -56,7 +58,7 @@
   if(result < 0) {
     kfree(view);
     kfree(kres);
-    __dbg_printk(_B_RED "Tty kres registration failed\n" _B_NORM);
+    DEBUG_PRINT2("Devfs register failed : %s\n", strerror(result));
     return result;
   }
 
@@ -66,6 +68,7 @@
       devfs_unregister(tty->devfs_device);
       kfree(view);
       kfree(kres);
+      DEBUG_PRINT2("Ures open failed : %s\n", strerror(result));
       return result;
     }
 
@@ -76,9 +79,10 @@
       devfs_unregister(tty->devfs_device);
       kfree(view);
       kfree(kres);
+      DEBUG_PRINT2("Register char to file view failed : %s\n",
+		   strerror(result));
       return result;
     }
 
   return 0;
 }
-

Index: _tty.c
===================================================================
RCS file: /home/kos/cvs/kos/modules/tty/_tty.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -d -r1.18 -r1.19
--- _tty.c	6 Jan 2005 20:15:57 -0000	1.18
+++ _tty.c	30 Jan 2005 16:11:21 -0000	1.19
@@ -111,6 +111,8 @@
   result_t result;
   void *output;
 
+  DEBUG_PRINT3("[_tty_init_lvl3] begin\n");
+
   keymap_init();
 
   /* Start after the special kernel tty slot */
@@ -144,6 +146,8 @@
 	return -ENOMEM;
       }
 
+      memset(tty, 0, sizeof(tty_t));
+
       /* Initialize it */
       tty->output = output;
       tty->width  = width;